Mod profiling support #1557
Closed
Mod profiling support #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,18 @@ function core.register_chatcommand(cmd, def) | |||
| core.chatcommands[cmd] = def | |||
| end | |||
|
|
|||
| if (core.is_yes(core.setting_get("tracing"))) then | |||
|
We've got server step spikes in minetest_game of about 1s, lots of mods suffer from bad programming. This is definitively not a low prio enhancement. |
|
This doesn't solve the problem, not high priority. |
|
If you really wanna keep ppl asleep because they have no chance to find out what they're doing wrong this is low prio for sure. As you're part of minetest_game support team please fix farming ... but don't use this pull as it's low prio and not needed to do it. ;-) |
| local tracefct = profiling_print_log | ||
| profiling_print_log = nil | ||
| core.register_chatcommand("save_mod_profile", | ||
| { |
sapier
force-pushed
the
luamod_tracing
branch
6 times, most recently
from
6462a2e
to
bba7b92
Compare
Config settings: profiling = true/false (gather statistics) detailed_profiling = true/false (break mod times to callbacks) Chat commands: save_mod_profile saves current statistics in debug.txt and shows on console (on default loglevel)
|
|
||
| -------------------------------------------------------------------------------- | ||
| local function initialize_profiling() | ||
| core.log("action", "Initialize tracing") |
|
merged 0c94f2fb64ff54edca790a7106ec43bbfb884058 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config settings:
profiling = true/false (gather mod statistics)
detailed_profiling = true/false (break mod times to callbacks)
Chat commands:
save_mod_profile saves current statistics in debug.txt and shows on console (on default loglevel)
Example what you're gonna see:
https://gist.github.com/sapier/4629aa2acfa1b943df97