Fixed using unitialized variables in mouse button handling #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (event.EventType == EET_MOUSE_INPUT_EVENT | ||
| && event.MouseInput.Event == EMIE_MOUSE_MOVED | ||
| && event.MouseInput.isRightPressed() | ||
| && getItemAtPos(m_pointer).i != getItemAtPos(m_old_pointer).i)) { |
There was a problem hiding this comment.
Since event.EventType == EET_MOUSE_INPUT_EVENT is checked in both sides of the "or" you can move it out and do:
- if((event.EventType==EET_MOUSE_INPUT_EVENT &&
- event.MouseInput.Event != EMIE_MOUSE_MOVED) ||
- (event.MouseInput.Event == EMIE_MOUSE_MOVED &&
- event.MouseInput.isRightPressed() && getItemAtPos(m_pointer).i != getItemAtPos(m_old_pointer).i)){
+ if(event.EventType == EET_MOUSE_INPUT_EVENT &&
+ (event.MouseInput.Event != EMIE_MOUSE_MOVED ||
+ (event.MouseInput.Event == EMIE_MOUSE_MOVED &&
+ event.MouseInput.isRightPressed() &&
+ getItemAtPos(m_pointer).i != getItemAtPos(m_old_pointer).i)) {
ShadowNinja
added
@ Client / Audiovisuals
@ Startup / Config / Util
Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #1707
event.MouseInput.Event is not initialized if event.EventType != EET_MOUSE_INPUT_EVENT and the previous code didn't check that EET_MOUSE_INPUT_EVENT was indeed the event type before checking the MouseEvent (and it was therefore invalid/not initialized).