Fixes #1687 by extra semaphore retval handle code for OSX

[neoascetic]

See #1687 (comment)

[neoascetic]

Or maybe removing of assertion is better?

[smarek]

Indeed fixing the issue, I've just tested. Thank you.
However compiled version cannot grab my controls (keyboard, mouse clicking works fine), could this fix influence that?

[neoascetic]

Yeah :)
Seems like odd bug somewhere between OSX and Irrlicht.
Try to create folder named "Contents" in the same folder where binary is, and see the magic.

[smarek]

Well, that's just perfect, oh great wizard @neoascetic :D

[smarek]

@kwolekr @kahrl
Can I ask you to merge this pull request, as it is essential for minetest to be osx/bsd compatible, or put out a review/info, why this cannot be merged, if that's the case? Thank you

[kwolekr]

This patch doesn't do anything worse than already exists in the source file, so I'll approve of it right now as a fix.

jthread/posix/jsemaphore.cpp as a whole needs to be cleaned up ASAP. Where does it say errno can be used as an lvalue? Is sem_wait() supported on OSX but all the other sem_* functions aren't? No? A macro redefined those functions? Why does it maintain its own semaphore count? The code itself is pretty disorganized too. This shit is FUBAR. I can't believe the previous commit(s) got approval.

[Zeno-]

commit a0ac471