Hide minetest version string

[SmallJoker]

Version is still visible in the debug view.

Source of this idea:

[ShadowNinja]

This is intentional. It's helpful to determine what version of Minetest a screenshot showing a bug was taken in. You can still remove it by disabling the hud and chat, if you want to take a screenshot with no extras.

[KenneyNL]

Could hiding the version number be added as an option to minetest.conf then? By default on.

[sapier]

release versions don't show this string for dev version hiding is NOT an option because to be able to check bugs we actually need it. And dev versions only purpose is finding bugs.

[MoNTE48]

Good idea :)
Edit: on code error:

jni/../jni/src/game.cpp: In member function 'void Game::updateGui(float*, const RunStats&, const GameRunData&, irr::f32, const VolatileRunFlags&, const CameraOrientation&)':
jni/../jni/src/game.cpp:3938:52: error: 'VERSION_EXTRA_STRING' was not declared in this scope
  } else if ((flags.show_hud || flags.show_chat) && VERSION_EXTRA_STRING != "") {

[SmallJoker]

@MoNTE48 Sorry, I can't reproduce this error. I successfully compiled it with msbuild.

EDIT: Fixed.

[rubenwardy]

It does look unprofessional.

I'd considered a method of encoding the Minetest version in a way that can't be visibly seen, but you could retrieve it with a piece of software, but that would decrease rendering times and could be a pain to find out the version. When pressing f12 you could encode the Minetest version in the file as metadata.

[sapier]

rubenwardy various image paste sites do reencode and drop metadata. I don't see any reason to rely on a possibly broken mechanism if someone uses a debug build.

[rubenwardy]

When pressing f12 you could encode the Minetest version in the file as metadata.

Yes that is the problem of above.

---

I'd considered a method of encoding the Minetest version in a way that can't be visibly seen, but you could retrieve it with a piece of software, but that would decrease rendering times and could be a pain to find out the version

But when I was talking about that, I meant rendering an invisible watermark to tell which version it is. Like this: http://en.wikipedia.org/wiki/Digital_watermarking Of course this isn't a good solution as it decreases rendering times.

---

The version string looks very unprofessional. It says something about this game that we keep text on the screen, even though it decreases how the game looks, because it is 'helpful' when debugging crashes (and this is only if the reporter doesn't tell us the Minetest version.) Sure, show them in dev versions, just not release versions.

---

@SmallJoker: please change the title to be the same as the commit. (ie: only show minetest version string on dev builds)

[ShadowNinja]

Only put the version string in debug builds.

Most users don't run debug builds, so this doesn't help. On the contrary, if you're using a debug build you probably know enough to report the version as part of the issue.

In official builds this is just Minetest 1.2.3 or similar. It's definitely not a big ugly overlay. In fact, that seems helpful to users too. At longest it's Minetest 1.2.3-extra-123-g012345678-dirty, but that's for a modified dev build with VERSION_EXTRA set.

[rubenwardy]

Who were you quoting, @ShadowNinja ?

[ShadowNinja]

@rubenwardy Multiple people, that's why I didn't specify.

[SmallJoker]

Okay I see this has no potential because it's needed to see which Minetest version is used in bug reports.