Fix time of day skew update and store almost all time related stuff in Atomic #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store almost every time related variable in Atomic or GenericAtomic: * Store the time of day into a storage Atomic<u64> so that the integral time of day doesn't get set differently than the float time of day in a race. * Only the skew needs a lock now. There is no other way however than to use a lock, except removing the lock and hoping the best. floats can't get non-generic atomic operations, not with the current support of gcc. C++11 has an abstraction layer for them, but there is no widespread implementation in hardware, so the abstraction layer uses some "bad" mechanism as well like a lock or similar. Fix the skew update so that it is added to as well, not just substracted from. This has been a regression of commit [1]. atomic.h changes: * Add GenericAtomic<T> class for non-integral types like floats. * Remove some last remainders from atomic.h of the volatile use. [1] f9b0936 "Time: Remove serverside getter, and use atomic operations"
est31
force-pushed
the
time_of_day_almost_lock_free
branch
from
ad937b6
to
d3cd30b
Compare
|
The bug got fixed in 8f03995, and the atomics implemented in this PR are very much against KISS for no reason, performance is not this strict here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store almost every time related variable in Atomic or GenericAtomic:
Fix the skew update so that it is added too, not just substracted from.
This has been a regression since commit [1].
atomic.h changes:
* Add GenericAtomic class for non-integral types like floats.
[1] f9b0936 "Time: Remove serverside getter, and use atomic operations"