Send to clients only changed node metadata instead of whole mapblock #3775
Conversation
RealBadAngel
force-pushed
the
meta_stuff
branch
from
48c7e71
to
9a1d2c7
Compare
RealBadAngel
changed the title
est31
added
the
WIP
RealBadAngel
force-pushed
the
meta_stuff
branch
from
2780f66
to
84ca32c
Compare
|
i don't think protocol should be bumped. v27 was created during this devel cycle and less than 1 month ago. |
| writeU16(os, p.Y); | ||
| writeU16(os, p.Z); | ||
| } else { | ||
| u16 p16 = p.Z * MAP_BLOCKSIZE * MAP_BLOCKSIZE + p.Y * MAP_BLOCKSIZE + p.X; |
There was a problem hiding this comment.
i don't think this compression is useful; you only add calculs on server side & client side for 4 bytes of data
There was a problem hiding this comment.
@nerzhul 1. the calculations are quite lightweight as MAP_BLOCKSIZE is power of two, probably writing the u16 to the array would require more computation (putting the stuff to the array, incrementing the counter every time times), I guess compilers optimize this to a shift, and 2. changing this would require a change of the map format.
|
RBA is apparently seriously ill in hospital and won't be able to work on this, perhaps someone can take over on this PR? |
|
@paramat I'll first get my two PRs into reviewable state and then take care of this one, it already is in a very good state. |
Rebased and improved #3166
fixed so far:
TODO:
all goals achieved :)