Added option to disable entity selectionboxes.

[sofar]

Setting only loaded once, default value is true.

Squashed and rebased by sofar.

[ghost]

Setting false as default will be better for new players imho.

[Zeno-]

I wish we'd implemented the callback thing to notify "local caches" of settings changes, but 👍

[p5yk0g3n3s1s]

Could you please add this: #1645 (comment)

I'm sure I'm not the only one who'll appreciate it. @tenplus1

[sofar]

@MT-Modder No, I'm not going to add it.

I rebased it because I think -given the thread- that everyone was OK with the patch as-is.

Adding new features breaks the discussion down and likely delays merging this patch. Any new features should be a separate PR.

[p5yk0g3n3s1s]

Okay understandable. I definitely don't want to delay something that works as is.

[est31]

@Zeno- we have implemented it actually, see a670ecf for example.

[est31]

@sofar can you add defaultsettings.txt documentation?

[est31]

And perhaps rename to show_entity_selectionboxes

[est31]

Tracking @Zeno- 's approval. I 👍 if the two comments above are addressed.

[sofar]

@est31 I'm assuming you meant to update the gettext dummy and add minetest.conf examples. Which I did. I also renamed it to "show_entity_selectionboxes".

repushed.

[est31]

Ah yeah I meant settingtypes.txt of course. Will merge.