Allow flooding to cause item drops

[cyisfor]

Non-air nodes can be defined as floodable, and now they'll drop their contents rather than just being replaced with air.

[PilzAdam]

AFAIK it's intentional that items are not dropped if they are flooded by water.

[est31]

IMO the engine should allow for whatever mods want, even for really bad ideas like letting liquids drop plants. Its a griefer's wet dream...

[Thomas--S]

I suggest to make the behaviour configurable.

[paramat]

Yes 'floodable' is to allow liquid to flow into vacuum, alien atmosphere, gas or any airlike nodes, which should not be dropped.
There is some discussion about if or how to implement optional drops, but i am not keen on making liquid drop nodes as items, see minetest/minetest_game#829 for my reasons.
If it is done it seems best to have an 'on_flood' callback, but i'm unconvinced there's enough need to justify adding this callback. Torches seems the only acceptable use.
👎

[PilzAdam]

@est31 maybe change the floodable field to allow specifying that nodes should be dropped when flooded?

[sofar]

I don't think it can be as simple as this anyway.

If there is an on_flood() callback, at least you can pass the liquid as a parameter, so that the callback function can decide whether to have the node destroyed (by e.g. lava) or dropped (by e.g. water), or maybe something else (enable a generator of some sorts, or heat a furnace, etc.).

I'm somewhat positive about the concept, but I think this is too simple.

[tenplus1]

@sofar - So an example for something like lava source would be:

on_flood = function(pos, liquidnode)
    if minetest.get_item_group(liquidnode.name, "water") > 0 then
        minetest.set_node(pos, {name = "default:obsidian"}
    end
end,

... thus saving on using an Abm to do the same action.

[paramat]

^ Good idea.

[sofar]

Yes, something like that is what I had in mind.

[sofar]

👎 I don't feel this is right, at all, and would be much more interested in seeing an on_flood() callback implementation as discussed above.

[paramat]

There is general dev agreement that an on_flood callback is the way to do this.