Disable "Ignoring CONTENT_IGNORE redefinition" warning

[HybridDog]

Addresses #6276

[t4im]

Will need some fields more, if you do it without register_node.

    name = "ignore",
    mod_origin = core.get_current_modname()

You probably should also have its metatable __index point to core.nodedef_default

[HybridDog]

@t4im fixed

[sofar]

OK for me, it kind of makes sense? 👍. I can see this being useful for other things like hand, air and a few more things.

[paramat]

Build problems?

[SmallJoker]

Looks good but I would prefer another term for easier understanding. How about is_core_content or is_predefined?

[HybridDog]

l agree; l called it pass_to_core.

@paramat it disappeared after rebasing

[rubenwardy]

I'm not completely sure about this. Is this because air and ignore can't be redefined?

[nerzhul]

it seems a little bit hacky for a single node, maybe we should just merge contentfeatures ?

[HybridDog]

When making mods you can use this to e.g. add the on_blast function to some node definition without redundantly passing everything to minetest core.

[nerzhul]

No don't do that it permits to prevent node définitions conflicts for mods => obsolete comment

[paramat]

Context: I deleted my comment, that was just before nerzhul's, where i suggested moving the message to infostream.

[HybridDog]

Could anybody donate a second approval?

[paramat]

How about just disabling the warning for the ignore node only, to keep it simple?

[HybridDog]

Do you mean explicitly avoiding printing this warning when the node is CONTENT_IGNORE?

[paramat]

Yes, but it's just a suggestion, it might not be a good idea.

[HybridDog]

l think that would be a workaround. The "ignore" node is overriden in register.lua that mods which use node definitions (e.g. minetest.registered_nodes[minetest.get_node(pos).name]) can easily treat ignore like other nodes, e.g. test whether it's walkable.
Another solution is setting minetest.registered_nodes["ignore"] to nil, ignore would be treated like unknown nodes. But doing this may add compatibility problems.
So l think adding a pass_to_core field to the nodedef for registering is a more appropriate solution.

[HybridDog]

l could also temporarily override register_item_raw to an empty function when reregistering ignore. How do you think about it?

[rubenwardy]

I don't like this, it feels hacky and a misfeature just to prevent this warning. It feels like a lot of ugliness for a small issue. I suggest:

1. remove C++ definition of ignore, and give canonical definition in builtin. Then disallow any overriding.
2. make not registering core something that only happens to ignore

Number 2 sounds better to me.

It would be:

function core.register_item(name, itemdef)
    local is_overriding = core.registered_items[name]


    -- rest of function


    -- Don't register ignore with the engine
    if name ~= "ignore" then
        register_item_raw(name, def)
    elseif is_overriding then
        minetest.log("warning", "Ignoring CONTENT_IGNORE redefinition")
    end
end

[HybridDog]

Done

[paramat]

Thanks, no objections from me.
@rubenwardy

[paramat]

👍

[Wuzzy2]

Hmmm. I'm not sure if I understood this right.

Does this always disable the warning, or just when ignore is added by builtin?

IMO the warning does make sense when you try to overwrite ignore from a mod that is not builtin, so it should only be hidden when builtin tries to set it.

[rubenwardy]

That's what will happen

[red-001]

use the core namespace in builtin.

[paramat]

Please do.

[HybridDog]

Done,
l also changed the comment because avoiding mods to register ignore to core is just a redundant side effect.

[paramat]

👍

[Wuzzy2]

@rubenwardy: You answer was not hellpful. :-(
Now what will happen?

[HybridDog]

It avoids registering ignore to core if it's registered the first time in lua, i.e. in builtin.
As side effect, for subsequent ignore registrations it gives a warning instead of attempting to register to core (which would also only give a warning, just from the core side).

[Wuzzy2]

Ah, good. That's what I wanted to hear. :-)