Separate optional from required mod dependencies in main menu #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks good |
SmallJoker
reviewed
Nov 4, 2016
| end | ||
| toadd_hard = toadd_hard .. hard_dependencies[i] | ||
| end | ||
| for i=1, #soft_dependencies do |
There was a problem hiding this comment.
Or short: toadd_soft = table.concat(soft_dependencies, ",")
Empty entries can be avoided in the reading function above easily
There was a problem hiding this comment.
Yeah, good idea, it should be adopted in all places before merge.
|
Okay for me too |
|
@Wuzzy2 can you change the code according to @SmallJoker 's suggestions? Then this PR can be merged. |
|
Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the main menu. The listed mod dependencies are now separated in required and optional dependencies. The current approach is basically just just blindly pasting
depends.txt(including the question marks). The the main menu “Mods” tab,, if a mod has no dependencies, the string “No dependencies.” is shown.Screenshots: