When minimap is disabled in configuration, really disable it #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
reviewed
May 18, 2017
| @@ -51,7 +51,8 @@ ClientScripting::ClientScripting(Client *client): | |||
| InitializeModApi(L, top); | |||
| lua_pop(L, 1); | |||
|
|
|||
| LuaMinimap::create(L, client->getMinimap()); | |||
| if (client->getMinimap()) | |||
| LuaMinimap::create(L, client->getMinimap()); | |||
There was a problem hiding this comment.
If the minimap is NULL at this time, client side scripting won't be able to access to core.ui.minimap, right?
Please add a note to client_lua_api.md that this table may be nil if the minimap is disabled.
SmallJoker
approved these changes
May 18, 2017
|
yeah i don't do a PR without tests, and here it's simple as we invalidate a pointer, the failure case is a crash when every single action on minimap should be done :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We instanciate & create object, only rendering is now totally done. Here really disable it when configuration told us.