Cpp11 initializers: last src root changeset #6022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finish to migrate all src root folder files to C++11 constructor initializers
nerzhul
added
the
Maintenance
Zeno-
reviewed
Jun 21, 2017
| /* | ||
| The block from which the object was loaded from, and in which | ||
| a copy of the static data resides. | ||
| */ | ||
| v3s16 m_static_block; | ||
| v3s16 m_static_block = v3s16(1337,1337,1337); |
There was a problem hiding this comment.
What is the significance of 1337? Just a magic number?
src/subgame.h
Outdated
| @@ -38,14 +36,14 @@ struct SubgameSpec | |||
| std::string menuicon_path; | |||
|
|
|||
| SubgameSpec(const std::string &id_="", | |||
| const std::string &path_="", | |||
| const std::string &path_="", | |||
There was a problem hiding this comment.
we don't pad with spaces around '=' anymore?
| bool m_move_has_really_moved = false; | ||
| s64 m_move_downtime = 0; | ||
| bool m_move_sent_as_mouse_event = false; | ||
| v2s32 m_move_downlocation = v2s32(-10000, -10000); |
src/voxel.h
Outdated
| v3s16 MaxEdge; | ||
| }; | ||
|
|
||
| // unused | ||
| // unused | ||
| #define VOXELFLAG_UNUSED (1<<0) |
src/voxel.h
Outdated
| v3s16 MaxEdge; | ||
| }; | ||
|
|
||
| // unused | ||
| // unused | ||
| #define VOXELFLAG_UNUSED (1<<0) | ||
| // no data about that node | ||
| #define VOXELFLAG_NO_DATA (1<<1) |
|
👍 |
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
* Cpp11 initializers: last src root changeset Finish to migrate all src root folder files to C++11 constructor initializers
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
* Cpp11 initializers: last src root changeset Finish to migrate all src root folder files to C++11 constructor initializers
luk3yx
pushed a commit
to luk3yx/minetest
that referenced
this pull request
Mar 6, 2019
* Cpp11 initializers: last src root changeset Finish to migrate all src root folder files to C++11 constructor initializers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish to migrate all src root folder files to C++11 constructor initializers
also remove some unused parameters