Network cleanup #6310
Merged
Network cleanup #6310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nerzhul
commented
Aug 24, 2017
•
nerzhul
commented
- Move Connection threads to dedicated files (divide cpp file by 2 & make it more readable)
- ConnectionReceiveThread::processPacket now uses function pointer table to route MT packet types
- Remove many packet buffers copy (performance improval)
- Various code style fixes
* ConnectionReceiveThread::processPacket now uses function pointer table to route MT packet types * Various code style fixes
nerzhul
added
@ Build
* SharedBuffer cannot be copied anymore using Buffer * Fix many SharedBuffer copy (thanks to delete operator)
SmallJoker
reviewed
Aug 25, 2017
src/network/connectionthreads.cpp
Outdated
| std::list<BufferedPacket> timed_outs; | ||
|
|
||
| if (dynamic_cast<UDPPeer *>(&peer)->getLegacyPeer()) | ||
| channel.setWindowSize(g_settings->getU16("workaround_window_size")); |
There was a problem hiding this comment.
yes, i moved the code but didn't see that, what is that thing, i think i will remove it, it's too dangerous for a end user
SmallJoker
reviewed
Aug 25, 2017
src/network/connectionthreads.cpp
Outdated
| continue; | ||
| } | ||
|
|
||
| float resend_timeout = dynamic_cast<UDPPeer *>(&peer)->getResendTimeout(); |
There was a problem hiding this comment.
UDPPeer *udp_peer = dynamic_cast<UDPPeer *>(&peer);, shortens and improves readability on 9 lines.
SmallJoker
reviewed
Aug 25, 2017
src/network/connectionthreads.cpp
Outdated
| while ((!channel.queued_reliables.empty()) && | ||
| (channel.outgoing_reliables_sent.size() | ||
| < channel.getWindowSize()) && | ||
| (peer->m_increment_packets_remaining > 0)) { |
There was a problem hiding this comment.
Indents missing and redundant parentheses.
SmallJoker
approved these changes
Aug 25, 2017
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
* Move Connection threads to dedicated files + various cleanups * ConnectionReceiveThread::processPacket now uses function pointer table to route MT packet types * Various code style fixes * Code style with clang-format * Various SharedBuffer copy removal * SharedBuffer cannot be copied anymore using Buffer * Fix many SharedBuffer copy (thanks to delete operator)
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
* Move Connection threads to dedicated files + various cleanups * ConnectionReceiveThread::processPacket now uses function pointer table to route MT packet types * Various code style fixes * Code style with clang-format * Various SharedBuffer copy removal * SharedBuffer cannot be copied anymore using Buffer * Fix many SharedBuffer copy (thanks to delete operator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.