Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtin/settingtypes.txt: Update zoom description. #6443

Merged
merged 2 commits into from Oct 6, 2017
Merged

builtin/settingtypes.txt: Update zoom description. #6443

merged 2 commits into from Oct 6, 2017

Conversation

ghost
Copy link

@ghost ghost commented Sep 19, 2017

No description provided.

@SmallJoker SmallJoker added @ Documentation Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines labels Sep 19, 2017
@paramat
Copy link
Contributor

paramat commented Sep 20, 2017

Nice i forgot to update this, but it needs to be something like:
This requires the player object property 'can_zoom' to be true.

@paramat paramat added the Action / change needed Code still needs changes (PR) / more information requested (Issues) label Sep 20, 2017
@SmallJoker
Copy link
Member

SmallJoker commented Sep 20, 2017

Another suggestion:
Instead of mixing lua_api and the settings in this case, how about simply using Field of view while zooming in degrees. Requires to be allowed by server-sided mods. ?
Most players aren't modders, so this will be easier to understand for them.
More important: Where's the can_zoom table key/value documented @paramat ?

@paramat
Copy link
Contributor

paramat commented Sep 20, 2017

Yes i'm fine with Krock's suggestion.
I forgot to document it in lua_api.txt, sorry, will fix.

@SmallJoker SmallJoker merged commit 00ceec9 into minetest:master Oct 6, 2017
@sfan5 sfan5 mentioned this pull request Dec 5, 2017
sfan5 pushed a commit that referenced this pull request Dec 5, 2017
t0ny2 pushed a commit to t0ny2/minetest that referenced this pull request Jan 23, 2018
sfan5 pushed a commit that referenced this pull request Feb 2, 2018
sfan5 pushed a commit that referenced this pull request Feb 3, 2018
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 11, 2019
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action / change needed Code still needs changes (PR) / more information requested (Issues) @ Documentation Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants