c_converter: Function template for numeric fields, add v3s16 default #7090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
added
@ Script API
Maintenance
|
Thanks for this. |
paramat
reviewed
Mar 2, 2018
src/script/common/c_converter.h
Outdated
| } | ||
|
|
||
| template<class T> | ||
| bool getv3field(lua_State *L, int index, |
There was a problem hiding this comment.
Maybe the name should make it clear it is for v3 ints? getv3intField? We might add a 'get v3 float field' later.
There was a problem hiding this comment.
Right. Changed that one.
|
Thanks for doing better C++ :) |
nerzhul
approved these changes
Mar 3, 2018
minduser00
pushed a commit
to minduser00/minetest
that referenced
this pull request
Mar 18, 2018
minduser00
pushed a commit
to minduser00/minetest
that referenced
this pull request
Mar 18, 2018
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the c_converter functions to templates which can not be anywhere else than in headers.
Also adds an implementation of
getv3s16field_defaultfor #7070How to test