Camera: Improve subpixel movement #7319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
added
@ Client / Audiovisuals
Trivial
sfan5
approved these changes
May 12, 2018
sfan5
added
One approval ✅ ◻️
and removed
Trivial
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving the mouse cursor very, very slowly to the right or bottom, the camera never moves. However, when moving it into the other direction, the camera will always move. The problem behind this issue is that only entire pixel values are provided by Irrlicht (
v2s32) and we're resetting the mouse position continuously to such a rounded/floored value.Use case: Zoom & sniping with guns
How to test
minetest.conf:
mouse_sensitivity = 1.2or any other high valueMove the camera around, but stepwise - pixel by pixel and compare with before.