Dungeons: Fix duplication of y limit parameters #7359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramat
added
@ Mapgen
Maintenance
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 04fb109 i added dungeon y-limits to 'DungeonParams' so that either mapgens could use these (they never did) or these would become user-settable if 'DungeonParams' became accessible to users, as hmmmm planned to do (but they never did, he left MT).
More recently i added dungeon y-limits as new mapgen-specific parameters to make these settable by users, forgetting that this caused a duplication. This PR removes the original and unused y-limit parameters.
Like the cave parameters in mapgen parameters, it is a better implementation to move some dungeon parameters into mapgen parameters, so that they are set and stored per-world.