Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the console instead of a dedicated window when pressing keymap_chat/cmd #751

Closed
wants to merge 1 commit into from

Conversation

EXio4
Copy link
Contributor

@EXio4 EXio4 commented Jun 3, 2013

When pressing "T" (or "/"), open a console what is closed after pressing enter/return, instead of that "chat window".

@kahrl
Copy link
Contributor

kahrl commented Jun 3, 2013

pros:

  • console has history and more editing features
  • console shows more previous chat
  • allows looking around while typing
  • single interface for chatting, more interface unity
  • GUITextInputMenu can be deleted completely

cons:

  • may cause console bugs to trigger more often (like "the" F10 bug)
  • when going afk with the console open, you may not remember whether the console will go away after pressing enter
  • console opening animation may be disconcerting
  • console obscures more of the screen than the GUITextInputMenu
  • no copy/paste in console (this should be changed anyway)
  • cancelling the console with Esc opens the pause menu (this should probably be changed as well)

@EXio4
Copy link
Contributor Author

EXio4 commented Jun 3, 2013

GUITextInputMenu deleted; the pause menu doesn't open anymore when the console is open and you press escape

@PilzAdam
Copy link
Contributor

PilzAdam commented Jun 3, 2013

  • when going afk with the console open, you may not remember whether the console will go away after pressing enter

will be fixed by

  • cancelling the console with Esc opens the pause menu (this should probably be changed as well)

  • no copy/paste in console (this should be changed anyway)

This doesnt work for everyone in the normal text fields either, see #373

  • console obscures more of the screen than the GUITextInputMenu

This is caused by this

  • console shows more previous chat

and I think when you open the chat then you want to focus on the chat and not on the background. Also the color and alpha is configureable, so one can make it more transparent.

@xyzz
Copy link
Contributor

xyzz commented Jun 3, 2013

Unicode characters (non-ascii ones, I suppose) cannot be input in console.

@EXio4
Copy link
Contributor Author

EXio4 commented Jun 4, 2013

they even don't work for me in the "old" window, or the console.

@xyzz
Copy link
Contributor

xyzz commented Jun 4, 2013

They do work in chat window. Make sure you build with freetype enabled.

@EXio4
Copy link
Contributor Author

EXio4 commented Jun 5, 2013

I see, nevermind.

edit: "fixed" in #754 (here, at least); it needs testers though.

…at/cmd

and remove guiTextInputMenu and deprecated sign_hack "formspec"
@celeron55
Copy link
Member

There doesn't seem to have been much interest in this; reopen if needed.

It appears copy-paste support is something that matters at least to some people.

@celeron55 celeron55 closed this Jan 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Client / Audiovisuals Rebase needed The PR needs to be rebased by its author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants