-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File 'content_sao' splitted into folder 'src/server/object'. #7903
Conversation
PR lgtm, but I haven't done a diff to check for modifications To do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
header files should be .h instead of .hpp
Thanks. |
574cf52
to
26ee402
Compare
This PR seems good to me in concept. |
Concerning filenames, in #7902 moved files are not renamed, i guess there is some advantage to this. But where you are creating new files you are using PascalCase with no underscores. I think underscores make filenames more readable. |
More thoughts on filenames, see #7908 (comment) onwards. Removed my -1. |
As decided elsewhere, snake_case please. |
@nerzhul 's request "header files should be .h instead of .hpp" seems done. |
I prefer
|
0e3b135
to
39c54e1
Compare
Hey @paramat, I forgot this one. The goal of this PR was also to split a big file into multiple smaller files. |
i missed that PR, but now it's useless, i did the refacto + some code cleanups myself last week |
So as @SmallJoker asked, I'm splitting #7900 into two distinct PRs.