Test IPv6 on startup and disable its use on failure #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
using constant port 30003 is very bad. |
|
Would the server port (defaulting to 30000) or the singleplayer port (30011) be better? (FYI, the unit tests use 30001 and 30003.) |
|
i think user configured server port will be better |
ghost
assigned 
|
fixed in a different way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems that don't support IPv6, IPv6 currently has to be disabled manually. With this patch IPv6 is tested on startup if it is enabled. If the test fails, a warning is printed and IPv6 is disabled for the time being. This patch addresses #793.