[WIP] Add URL button #8139
[WIP] Add URL button #8139
Conversation
rubenwardy
added
WIP
src/porting.cpp
Outdated
| #ifdef _WIN32 | ||
| return system((std::string("open ") + url).c_str()) == 0; | ||
| #else | ||
| return system((std::string("xdg-open ") + url).c_str()) == 0; |
There was a problem hiding this comment.
I'm really not happy with this method of opening URLs, but I couldn't find a better way
There was a problem hiding this comment.
Did you try this on android? IIRC you will need to use JNI/java for this but I haven't tested it. Maybe xdg-open works there, too.
There was a problem hiding this comment.
yeah, this doesn't support Android yet. I need to find out how to call Java functions from this part of the code, so I can then use intents to open the browser
There was a problem hiding this comment.
It should be easy enough, you will just need too add another JNI call in porting_android.cpp
|
Alternatively: core.open_url(url)
player:open_url(url)This would make it easier to make sure the it's never possible for The abuse of such a method in-game worries me, but worth discussing |
|
And maybe ability to open a changelog page for new minetest update... |
| @@ -3629,6 +3685,14 @@ bool GUIFormSpecMenu::OnEvent(const SEvent& event) | |||
| return true; | |||
| } | |||
|
|
|||
| if (!s.url.empty()) { | |||
| if (m_client) { | |||
| errorstream << "Unable to use button_url in game!" << std::endl; | |||
There was a problem hiding this comment.
it sounds a little bit hacky to have those m_client tests
There was a problem hiding this comment.
Is there a better way to detect if we're in the menu or not? Probably to use the core.open_url approach instead of a button
| #ifdef _WIN32 | ||
| return system((std::string("open '") + url + "'").c_str()) == 0; | ||
| #else | ||
| return system((std::string("xdg-open '") + url + "'").c_str()) == 0; |
| @@ -697,6 +699,21 @@ int mt_snprintf(char *buf, const size_t buf_size, const char *fmt, ...) | |||
| return c; | |||
| } | |||
|
|
|||
| bool openURL(std::string url) | |||
Adds a formspec element to open URLs in a browser.
Note that this is only enabled in the mainmenu (currently)
This cannot be used whilst in-game, due to the obvious issues. I'd like to add support for this eventually, with a confirmation dialog showing the requested URL. But this would should not be done in this PR
Usecase
The use case in mind is allowing a button to open up the ContentDB pages of packages.
To implement reviews and comments, I don't want to have to add login support to the client. Instead, I'd prefer to have a button to open up ContentDB in a web browser.
To do