Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline before itemstring in item tooltip #8213

Merged
merged 1 commit into from Mar 17, 2019

Conversation

Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Feb 9, 2019

Because I think it's a bit more pleasant to read that way because the “real” item name and the internal one are visually more separated.

How to test:

  1. Enable tooltip_append_itemname
  2. Start a game and hover some items

@Wuzzy2
Copy link
Contributor Author

Wuzzy2 commented Feb 9, 2019

Also, the tooltip for “Blueberry Bush Leaves with Berries [default:blueberry_bush_leaves_with_berries]” is too long when on a single line. ;)

@paramat
Copy link
Contributor

paramat commented Feb 10, 2019

Yes good idea to avoid long lines.
Assuming you've tested 👍

@Wuzzy2
Copy link
Contributor Author

Wuzzy2 commented Feb 11, 2019

Yes, tested.

@ClobberXD
Copy link
Contributor

Yay, 3 approvals! :)

@SmallJoker SmallJoker merged commit 9f1b98b into minetest:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants