Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Add inventory_overlay for nodes without inventory_image #8433

Merged
merged 1 commit into from Aug 7, 2019

Conversation

Desour
Copy link
Member

@Desour Desour commented Mar 30, 2019

Closes #8430.
There might be many mistakes.

How to test this:

minetest.register_node("test_invcube:node", {
	description = "inventorycube node",
	tiles = {"unknown_item.png"},
	inventory_overlay = "camera_btn.png",
	groups = {oddly_breakable_by_hand = 3},
})

Here's a sceenshot:
screenshot
As you can see, the rotating of the node also works (inventory_items_animations).

If the inventory_overlay image is not quadratic, it is squashed in one direction (try with progress bar texture).

@ClobberXD
Copy link
Contributor

Awesome. Will test today.

@ClobberXD
Copy link
Contributor

It works! (Note that I've only tested it with the code linked to in #8430)

@paramat paramat added the Bugfix 🐛 PRs that fix a bug label Mar 31, 2019
@sfan5 sfan5 merged commit 1cef09f into minetest:master Aug 7, 2019
@Desour Desour deleted the inv_overlay branch August 7, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inventory_overlay is ignored when item does not define inventory_image
6 participants