Add formspec rendering automated testing #8615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenwardy
added
@ Client / Audiovisuals
WIP
|
|
Desour
reviewed
Jun 20, 2019
Desour
reviewed
Jun 20, 2019
Co-Authored-By: DS <vorunbekannt75@web.de>
Co-Authored-By: DS <vorunbekannt75@web.de>
|
I think I opened this too early, so closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements unit testing of formspec rendering by using the mainmenu to render formspecs. It adds core.take_screenshot and core.on_step to the main menu API. The former is used to create images of the GUI, and the latter is used to interact with the render step.
The aim of this PR is to make PRs like #8524 and #7970 less risky.
To do
How to test
Todo