Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formspec: change the appearance of the cursor on fields and co. #8665

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

Desour
Copy link
Member

@Desour Desour commented Jul 9, 2019

Fixes #8523.

(There's a small bug: If you open a formspec and have your cursor on an element, it will stay normal until you move it away and back.)

To do

This PR is a Ready to Review.

How to test

  • Start minetest.
  • Join or start a game.
  • Wait until you are connected.
  • Press esc.
  • Hover with you mouse over the text and look at your cursor.

It would be good if users of different operating systems could test this. I'm only able to test with Linux Lubuntu 18.04.

@Desour
Copy link
Member Author

Desour commented Jul 9, 2019

Ok, now it the cursor changes instantly. I overlooked the && delta >= m_tooltip_show_delay and instead looked for problems in irrlicht. >_<

Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely.

@Desour
Copy link
Member Author

Desour commented Jul 19, 2019

Thanks @SmallJoker!

But note that, according to irrlicht docs, this probably doesn't work for mac users.

@rubenwardy rubenwardy added this to Highest priority on top in Formspec Priority List Aug 8, 2019
@Desour
Copy link
Member Author

Desour commented Sep 5, 2019

Later in another PR, other cursor icons could optionally be used for other elements, eg. hand for buttons, a little bit related: #8901.

@SmallJoker SmallJoker changed the title Formspec: change the appeareance of the cursor on fields and co. Formspec: change the appearance of the cursor on fields and co. Dec 3, 2019
@SmallJoker SmallJoker added the Rebase needed The PR needs to be rebased by its author. label Dec 3, 2019
@SmallJoker
Copy link
Member

@DS-Minetest Needs rebase and someone else who's keen to review these few changed lines.

@Desour
Copy link
Member Author

Desour commented Dec 7, 2019

Rebased.

@SmallJoker SmallJoker removed the Rebase needed The PR needs to be rebased by its author. label Dec 7, 2019
@rubenwardy
Copy link
Member

@SmallJoker what platform did you test on? This is the sort of thing that could cause issues due to dodgy implementations on other platforms

@SmallJoker
Copy link
Member

@rubenwardy Linux, Xubuntu 18.04. It's really not a good comparison among different platforms but Minetest surely isn't the first app that makes use of different cursors (in Irrlicht).

@SmallJoker
Copy link
Member

@SmallJoker SmallJoker merged commit 4c8af54 into minetest:master Jan 11, 2020
Formspec Priority List automation moved this from PRs: Highest priority on top to Done Jan 11, 2020
@Desour Desour deleted the form_cursor branch January 12, 2020 17:29
aldum pushed a commit to banyamesterseg/minetest that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

formspec: mouse cursor should look different when hovering over fields
5 participants