-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formspec: change the appearance of the cursor on fields and co. #8665
Conversation
Ok, now it the cursor changes instantly. I overlooked the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely.
Thanks @SmallJoker! But note that, according to irrlicht docs, this probably doesn't work for mac users. |
Later in another PR, other cursor icons could optionally be used for other elements, eg. hand for buttons, a little bit related: #8901. |
@DS-Minetest Needs rebase and someone else who's keen to review these few changed lines. |
Rebased. |
@SmallJoker what platform did you test on? This is the sort of thing that could cause issues due to dodgy implementations on other platforms |
@rubenwardy Linux, Xubuntu 18.04. It's really not a good comparison among different platforms but Minetest surely isn't the first app that makes use of different cursors (in Irrlicht). |
Fixes #8523.
(There's a small bug: If you open a formspec and have your cursor on an element, it will stay normal until you move it away and back.)
To do
This PR is a Ready to Review.
How to test
It would be good if users of different operating systems could test this. I'm only able to test with Linux Lubuntu 18.04.