New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attachments: Fix attachments to temporary removed objects #8989
Conversation
b4b0ac5
to
7d9e4b6
Compare
I tested this PR and it fixes my reported bug it seems. If the cart with the player is too far away the cart unloads and the player model floats above ground so the position even updates when entity is out of sight which is actually something good I think. |
This PR makes behavior inconsistent between 5.0.1 and 5.1.0 clients though: 5.1.0 client
5.0.1 client
|
We can't fix broken behaviour of older releases of Minetest clients. |
@IhrFussel I am well aware of this difference. In fact, I added it on purpose. Do you really want to go back to the buggy behaviour? Doubt it. EDIT: There are a few more issues regarding unloaded entities but this PR should be enough for the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Fixes #8929 by not clearing the attachment upon object removal.
To do
This PR is Ready for Review.
How to test
Imported from #8929:
Now do this for various combinations of
player_transfer_distance
andactive_block_range
:Additional tests: #8701 (to confirm that it still works as intended)