Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tunnels: Completely disable generation when 'cave width' >= 10 #9093

Merged
merged 1 commit into from Nov 9, 2019
Merged

Tunnels: Completely disable generation when 'cave width' >= 10 #9093

merged 1 commit into from Nov 9, 2019

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Nov 8, 2019

Previously, the only way to disable the 3D noise tunnels was to set
'cave width' > 1, however doing so did not disable the very intensive
noise calculations or the generation loop.
All the other types of cave generation (randomwalk caves, caverns)
could already be independently and completely disabled.
This feature is now needed more because the small randomwalk caves are
now available for use as an alternative to the 3D noise tunnels.
///////////////////////////////////////////

Has been tested by adding a printf() after noise calculations to check those are not triggered.

@paramat paramat added @ Mapgen Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Feature ✨ PRs that add or enhance a feature WIP The PR is still being worked on by its author and not ready yet. labels Nov 8, 2019
@paramat
Copy link
Contributor Author

paramat commented Nov 8, 2019

Will change value to 10 as suggested by SmallJoker.
EDIT:
Done.

Previously, the only way to disable the 3D noise tunnels was to set
'cave width' > 1.0, however doing so did not disable the very intensive
noise calculations or the generation loop.
All the other types of cave generation (randomwalk caves, caverns)
can already be independently and completely disabled.
This feature is now needed more because the small randomwalk caves are
now available for use as an alternative to the 3D noise tunnels.
@paramat paramat changed the title Tunnels: Completely disable generation when 'cave width' >= 1000 Tunnels: Completely disable generation when 'cave width' >= 10 Nov 8, 2019
@paramat paramat removed the WIP The PR is still being worked on by its author and not ready yet. label Nov 8, 2019
@paramat paramat merged commit 29a4a8e into minetest:master Nov 9, 2019
@paramat paramat deleted the tunneloption branch November 19, 2019 20:31
MoNTE48 pushed a commit to MoNTE48/minetest that referenced this pull request Jan 11, 2020
…etest#9093)

Previously, the only way to disable the 3D noise tunnels was to set
'cave width' > 1.0, however doing so did not disable the very intensive
noise calculations or the generation loop.
All the other types of cave generation (randomwalk caves, caverns)
can already be independently and completely disabled.
This feature is now needed more because the small randomwalk caves are
now available for use as an alternative to the 3D noise tunnels.
aldum pushed a commit to banyamesterseg/minetest that referenced this pull request Apr 16, 2020
…etest#9093)

Previously, the only way to disable the 3D noise tunnels was to set
'cave width' > 1.0, however doing so did not disable the very intensive
noise calculations or the generation loop.
All the other types of cave generation (randomwalk caves, caverns)
can already be independently and completely disabled.
This feature is now needed more because the small randomwalk caves are
now available for use as an alternative to the 3D noise tunnels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature ✨ PRs that add or enhance a feature @ Mapgen Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant