GUIFormSpecMenu: Add basic element highlighing debug feature #9423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 22, 2020
Desour
reviewed
Apr 5, 2020
src/gui/guiFormSpecMenu.cpp
Outdated
Comment on lines
3289
to
3290
| hovered->getAbsoluteClippingRect(), | ||
| &hovered_pos); |
There was a problem hiding this comment.
Parameters are color, pos, *clip, not color, clip, *pos. http://irrlicht.sourceforge.net/docu/classirr_1_1video_1_1_i_video_driver.html#ac7f452fae0ef8abe01768a78ba7033b7
(Just using the clipping rect would also suffice.)
There was a problem hiding this comment.
Nice catch, thank you. I adjusted the PR accordingly.
SmallJoker
force-pushed
the
formspec_debug
branch
2 times, most recently
from
222c318
to
3e2bc25
Compare
SmallJoker
force-pushed
the
formspec_debug
branch
from
3e2bc25
to
78bc2a1
Compare
rubenwardy
approved these changes
Apr 11, 2020
|
Nice. |
aldum
pushed a commit
to banyamesterseg/minetest
that referenced
this pull request
Apr 16, 2020
…t#9423) Activated using F5
nerzhul
pushed a commit
to nerzhul/minetest
that referenced
this pull request
Apr 27, 2020
…t#9423) Activated using F5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a highlighting feature to all formspecs which can be enabled using the debug key.
Possible additions in the future: a static text to describe the highlighted element (type name, ID, etc)
To do
This PR is Ready for Review.
How to test