New appletree schematic

[paramat]

I have been unhappy with the appletree schematic for a long time.
Screenshot shows a version with no per-node probability to show the form better (and no height variation). The PR has some of the outer leaves with probability 223 (7/8).

^ Sorry for opaque leaves but this shows the form better

Decoration density is reduced by the ratio of new to old tree schematic areas.

[paramat]

So don't comment.

[paanrama]

It is a pretty little tree, but I think it can have more fruit positions (maybe it can be done on external leaves).

Also can be an opportunity to use a slightly ligther green in the leaves.

[paramat]

Trees have an average of 1 apple per tree, so 4 fruit positions is plenty.
I don't want to put fruits on the outside as then leaves have to be removed, this spoils the outer shape of the crown. I like the apples being a little 'hidden' in the tree, otherwise it feels a little too easy and overly obvious. So i dislike the mgv6 trees.

[Fixer-007]

Updated comment: it simply feels like big same-looking umbrella, needs more variability?

[Napiophelios]

when walking around gathering things
you don't really notice much of a change;
but when you fly around, especially over dense areas,
its a more "aesthetically pleasing landscape".

:)

[paramat]

Fixer:

All screenshots show a version with no per-node probability to show the form better. The PR has some of the outer leaves with probability 223 (7/8).

[paramat]

PR updated to version with height variation.
Ready for review, sapling version and table docs will be updated once shape is appoved.

local M = {name = "default:leaves", prob = 255}
local N = {name = "default:leaves", prob = 223}
local F = {name = "default:apple", prob = 63}
local Y = {name = "default:tree", prob = 255, force_place = true}

mts_save("new_apple_tree_rand_slice", {
	size = {x = 7, y = 8, z = 7},
	data = {
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, N, M, N, _, _,
		_, _, _, N, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,

		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, M, M, F, M, M, _,
		_, N, M, M, M, N, _,
		_, _, N, M, N, _, _,
		_, _, _, _, _, _, _,

		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		N, M, _, _, _, M, N,
		_, M, Y, _, Y, M, _,
		_, N, M, M, M, N, _,
		_, _, _, N, _, _, _,

		_, _, _, Y, _, _, _,
		_, _, _, Y, _, _, _,
		_, _, _, Y, _, _, _,
		_, _, _, Y, _, _, _,
		M, F, _, Y, _, F, M,
		N, M, _, _, _, M, N,
		_, M, M, M, M, M, _,
		_, _, N, M, N, _, _,

		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		N, M, _, _, _, M, N,
		_, M, Y, _, Y, M, _,
		_, N, M, M, M, N, _,
		_, _, _, N, _, _, _,

		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, M, M, F, M, M, _,
		_, N, M, M, M, N, _,
		_, _, N, M, N, _, _,
		_, _, _, _, _, _, _,

		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
		_, _, N, M, N, _, _,
		_, _, _, N, _, _, _,
		_, _, _, _, _, _, _,
		_, _, _, _, _, _, _,
	},
	yslice_prob = {
		{ypos = 2, prob = 127},
	},
})

[Ezhh]

👍 for me with the height variation.

[paramat]

Added sapling version and updated table docs. Will do final test.

[paramat]

Had an idea to move 2 opposing branches down a node for a more interesting structure. A little like how the acacia tree has 2 branches a node lower.
Note this is not in the PR (yet).

I find this helps make the taller version not seem so high off the ground, because 2 branches are lower. The branches are now more visible from the side.
Looks better to me.

[Fixer-007]

Can you place branches more randomly somehow?

[Ezhh]

Rotation helps with randomness. The only other thing would be to add a low chance of not all branches appearing for every tree, but I don't think that's really needed.

[paramat]

Updated to new design.
Retested, found a couple of bugs due to forgetting to reset sapling protection check volume and the offset in 'place schematic' when it grows. Fixed.
So assuming +1 from Ezhh.