Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'killme' mod to 'game_commands' and add missing files #2199

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Rename 'killme' mod to 'game_commands' and add missing files #2199

merged 1 commit into from
Aug 24, 2018

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Aug 22, 2018 •
edited
Loading

Closes #2033
@Ezhh

@paramat paramat added this to the 5.0.0 milestone Aug 22, 2018
@SmallJoker
Copy link
Member

SmallJoker commented Aug 22, 2018 •
edited
Loading

There are two mods with this name already. They're both WIP mods but former has notable fresh content. If you'd like to work around it, then "gamecommands" might be also a fitting name.
Changing the mod name is a good idea to make it fitting for different chat commands.

@paramat
Copy link
Contributor Author

paramat commented Aug 22, 2018

Ok, 'mtg_commands' to reduce chance of name conflicts?

@paramat paramat added the WIP label Aug 22, 2018
@paramat paramat changed the title Rename 'killme' mod to 'commands' and add missing files Rename 'killme' mod to 'mtg_commands'(?) and add missing files Aug 22, 2018
@paramat paramat changed the title Rename 'killme' mod to 'mtg_commands'(?) and add missing files Rename 'killme' mod to 'mtg_commands' and add missing files Aug 23, 2018
@paramat paramat removed the WIP label Aug 23, 2018
@paramat
Copy link
Contributor Author

paramat commented Aug 23, 2018

Updated.

@Fixer-007
Copy link
Contributor

Fixer-007 commented Aug 23, 2018 •
edited
Loading

game_commands, in case mtg gets renamed some day

@paramat
Copy link
Contributor Author

paramat commented Aug 23, 2018 •
edited
Loading

Hmm good point thanks. Other core devs seem ok with game_commands so i'll change it.

@paramat paramat added the WIP label Aug 23, 2018
@paramat paramat changed the title Rename 'killme' mod to 'mtg_commands' and add missing files Rename 'killme' mod to 'game_commands' and add missing files Aug 23, 2018
@paramat
Copy link
Contributor Author

paramat commented Aug 24, 2018

Updated to 'game_commands'.

@paramat paramat removed the WIP label Aug 24, 2018
Ezhh
Ezhh approved these changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@Ezhh Ezhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you changed back to game_ again, but still fine for me. 👍

@paramat paramat merged commit 02c4a05 into minetest:master Aug 24, 2018
@paramat paramat deleted the dontkillme branch October 24, 2018 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

@Ezhh Ezhh Ezhh approved these changes

Assignees
No one assigned
Labels
Maintenance >= Two approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paramat @SmallJoker @Fixer-007 @Ezhh