-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plantlike_rooted coral #2254
Conversation
Now that's a very lovely decoration for the sea grounds. I'm looking forward to have this feature in MTG. |
Coral textures need to be indexed alpha. |
Note sidelen 4. |
I'm neutral.
…On Wed, Oct 31, 2018, 2:58 AM Paramat ***@***.***> wrote:
sidelen = 4,
noise_params = {
offset = -6,
scale = 4,
spread = {x = 100, y = 100, z = 100},
seed = 7013,
octaves = 3,
persist = 1,
},
Note sidelen 4.
This is fairly similar to previous distribution and rarity.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2254 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWXKYiQWjp9CqjzUt0t7HLBC5C0QnOQPks5uqUn9gaJpZM4X-Pxi>
.
|
Using the noise values suggested by @paramat, there are some very nice patches such as: But also found a weird square patch I am not so keen on. Unsure how common this might be. |
Not really WIP anymore, but still open to suggestions for changing drops and groups for the coral. |
Yes the noise is tricky, the square area is due to the 3rd octave of noise spiking up. I need to tune more, but i'm thinking merge anyway, tune later? |
Well, i'm neutral, you can merge if you want, or wait, i'll get working on tuning noise. |
I'm fine with merging and then you can look at adjusting more later. I only found that one area in the screenshot so far that didn't look good to me, so it's possible that it's rare. One thing I would like an opinion on first is the groups. |
'cracky = 3' seems maybe a little too much effort for thin fragile coral structures, being equal to a full stone node. |
That's what I am leaning more toward, it's just a bit odd when you have the combined structures due to the nature of the drawtype. |
Ok. but when dug only the top extension is dug. |
Yes, why I'm leaning toward it. Will change. |
2000x2000 map. Orange pixels in sea sand are corals (water not visible).
|
Remove coral from schematic_tables.txt Update noise Fix placement prediction Adjust images Fix drops Adjust groups Tidy up
Okay, rebased due to conflict and updated noise (I think that looks much better). |
This:
This is very much WIP.
In its current form placement looks like this:
Please note that noise needs to be adjusted and in this example I've set it to place huge amounts of coral just so we can get an idea of what it might look like.
To do:
Closes #2040