Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make screwdriver-rotating of placed nodes a natural ability #2321

Closed
paramat opened this issue Feb 23, 2019 · 17 comments
Closed

Make screwdriver-rotating of placed nodes a natural ability #2321

paramat opened this issue Feb 23, 2019 · 17 comments

Comments

@paramat
Copy link
Contributor

paramat commented Feb 23, 2019

I remember this was discussed somewhere.
It seems to me that the ability to rotate a node any way you want should be a natural ability, not something that requires the creation of a steel ingot (a fairly developed stage in game progress) and the crafting of a tool.
Stair and slab nodes can already be rotated upside down on placement without a special tool, but the other rotations of them require the screwdriver.

Not sure how to implement this though.
Items seem out of place in the engine so i'm not sure if rotation ability can be moved into the engine, or how to do that.
Maybe at first in MTG we can simply use the 'give initial stuff' API to give players a screwdriver?
EDIT:
Suggestions:
Make the screwdriver mod give a screwdriver to new players.
Perhaps disable wear for the screwdriver, as this should be a natural ability, which the screwdriver item acts as a symbol for.

@Fixer-007
Copy link
Contributor

I would rather keep screwdriver in game, it is used all over the place in mods (including in --)

@paramat
Copy link
Contributor Author

paramat commented Feb 23, 2019

Ok yes it will have to be kept in MTG whatever happens.

@Fixer-007
Copy link
Contributor

But having ability to naturally place them will be nice as well.

@Ezhh
Copy link
Contributor

Ezhh commented Feb 25, 2019

Maybe at first in MTG we can simply use the 'give initial stuff' API to give players a screwdriver?

Please let's not go this way. It's a lazy fix for something that doesn't actually need fixing (note: not the same as a better approach not being desirable) and not something everyone is going to want, but we'd be making this the default for so many things. It would also open up all kinds of awkwardness (if we start with screwdrivers, why not start with < many possible things > that are much more practical?)

The screwdriver exists in its current form because for gameplay purposes no one came up with something better. The way to improve it is actually coming up with something better, not just giving them out by default to new players.

@ghost
Copy link

ghost commented Feb 25, 2019 via email

@Ezhh
Copy link
Contributor

Ezhh commented Feb 25, 2019

Then it's pointless to have there regardless because it would not solve the issue. (I don't feel it's much of an issue at all either way.)

@paramat
Copy link
Contributor Author

paramat commented Feb 25, 2019

Yes using 'give initial stuff' for this is a little messy, although i think the API doesn't depend on that setting.

@benrob0329
Copy link
Member

Having the placement rules allow for all rotations (even if a little awkward in some circumstances) between holding and not holding shift would help immensely.

@ghost
Copy link

ghost commented Feb 28, 2019

Maybe place according to orientation. When someone wants to rotate they need a screwdriver. Otherwise they need to mine the node and re-place it in the desired rotation.

@paramat
Copy link
Contributor Author

paramat commented Jul 29, 2019

I think the screwdriver mod should give a screwdriver to new players.
It makes sense that a player should be able to place a node in any rotation they want as an inherent ability, so insisting on the smelting of steel before being able to create a screwdriver is rather harsh.

@ghost
Copy link

ghost commented Jul 29, 2019

Maybe implement the screwdriver as regular tool, so it can be crafted from wood, stone, etc. Unrealistic? Absolutely. But fits to MTG logic like wooden pickaxes that can mine stone 🙂

@TumeniNodes
Copy link
Contributor

Add a keybinding which switches the hand i to rotation mode and move the rotating code from the screwdriver to the hand

Done

@Desour
Copy link
Member

Desour commented Aug 14, 2019

Ripping out the node, drawing it and gluing it back to where it was before with just ones bare hands seems a little weird.
The rotation should normally done before placing. Something like a with-keys-rotatable ghosty node appearing client-side when you hold an item in your hand (or maybe while you hold the place button and sneak) would be nice, but that's an engine issue.

@paramat paramat changed the title Make screwdriver-rotating of placed nodes a natural ability Make screwdriver-rotating of placed nodes a natural ability (give screwdriver to new players?) Dec 21, 2019
@paramat paramat changed the title Make screwdriver-rotating of placed nodes a natural ability (give screwdriver to new players?) Make screwdriver-rotating of placed nodes a natural ability Dec 21, 2019
@paramat
Copy link
Contributor Author

paramat commented Dec 21, 2019

An engine solution may make the most sense, but will be complex and possibly cause problems with all the mods that work with the current screwdriver methods. I cannot face that, so i am proposing we make an imperfect but simple improvement.

@SmallJoker
Copy link
Member

For now it would be totally fine to remove the wear out functionality. Giving it to all players is superfluous because it'll only be useful when you start building a serious house (after hours in-game probably).

@paramat
Copy link
Contributor Author

paramat commented Dec 21, 2019

I disagree about it being superfluous, as the first rotatable nodes can be crafted long before acquiring steel. Besides, this is about the principle of rotating as an inherent ability that is there from the start.

@paramat
Copy link
Contributor Author

paramat commented Jul 27, 2020

Closing due to #2710

@paramat paramat closed this as completed Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants