Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unvisible trapdoor #411

Closed
Xanthin opened this issue Jan 22, 2015 · 5 comments
Closed

Unvisible trapdoor #411

Xanthin opened this issue Jan 22, 2015 · 5 comments

Comments

@Xanthin
Copy link
Contributor

Xanthin commented Jan 22, 2015

Just a small thing (matter of taste). The trap door, when selected in the hotbar, is not visible while standing. When you walk with the character it shows up but not really much.
I added: wield_image = "doors_trapdoor.png", to the trapdoor registration and now it's visible like other items (doors, rails,...).

Some pictures:

while standing


while walking


with my change

What do you think?

@kilbith
Copy link
Contributor

kilbith commented Jan 22, 2015

That it's obviously better and you should submit a PR.

@kilbith
Copy link
Contributor

kilbith commented Feb 1, 2015

... still waiting for a PR.

@Heybye44
Copy link

Heybye44 commented Feb 1, 2015

👍

@Xanthin
Copy link
Contributor Author

Xanthin commented Feb 4, 2015

Sorry, I am a totaly newbie with github and only use it in its browser version. I was concerned about messing up the history and causing more work for the admins then this tiny modification deserves.
PR is done. Thank you very much for the feedback :)

BlockMen pushed a commit to BlockMen/minetest_game that referenced this issue Feb 12, 2015
@BlockMen
Copy link
Contributor

047ecea

Lymkwi pushed a commit to Lymkwi/minetest_game that referenced this issue Feb 12, 2015
BuckarooBanzay pushed a commit to minetest-game/doors that referenced this issue Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants