Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document share_bones_time_early #823

Closed
wants to merge 1 commit into from
Closed

Document share_bones_time_early #823

wants to merge 1 commit into from

Conversation

red-001
Copy link
Contributor

@red-001 red-001 commented Feb 1, 2016

Fixes #819.

@paramat
Copy link
Contributor

paramat commented Feb 1, 2016

Please split the line into 2 roughly equal length lines.
Also for better English:
"How much earlier the bones of a dead player can be looted by
everyone if the player dies in a protected area they don't own."

@red-001 red-001 force-pushed the document_share_bone_time_early branch from 3243ef2 to 3db4bb1 Compare February 1, 2016 22:19
@red-001
Copy link
Contributor Author

red-001 commented Feb 1, 2016

@paramat done.

kaeza
kaeza reviewed Feb 2, 2016
View reviewed changes
minetest.conf.example
# How much earlier can the bones of a dead playerbe looted
# by everyone if the player dies in a protected area they don't own.
# 0 to disable.
# share_bones_time_early = share_bone_time / 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be set to 300, and the "default" of 1/4 moved to description. Also, remove the space between the # and the setting name.

@red-001 red-001 force-pushed the document_share_bone_time_early branch from 3db4bb1 to 8649d01 Compare February 3, 2016 15:45
@red-001
Copy link
Contributor Author

red-001 commented Feb 3, 2016

@kaeza done.

@paramat
Copy link
Contributor

paramat commented Feb 4, 2016

How much earlier can the bones of a dead player be looted
Better English needed, please move the 'can' as in my previous comment.

@paramat
Copy link
Contributor

paramat commented Feb 18, 2016

^ @red-001

@paramat
Copy link
Contributor

paramat commented Mar 2, 2016

Thanks please squash then i'll merge.

@red-001 red-001 force-pushed the document_share_bone_time_early branch from 0e2bdff to f736737 Compare March 2, 2016 23:31
@red-001
Copy link
Contributor Author

red-001 commented Mar 2, 2016

@paramat Done.

@paramat
Copy link
Contributor

paramat commented Mar 2, 2016

👍 WIll merge as is trivial.

@paramat
Copy link
Contributor

paramat commented Mar 3, 2016

3a98245

@paramat paramat closed this Mar 3, 2016
@paramat paramat mentioned this pull request Mar 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
One approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@red-001 @paramat @kaeza