Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background image to book formspec #849

Closed
wants to merge 1 commit into from
Closed

Add background image to book formspec #849

wants to merge 1 commit into from

Conversation

p5yg3n
Copy link
Contributor

@p5yg3n p5yg3n commented Feb 13, 2016

It probably doesn't change text visibility but I think it looks better because every other formspec has one.

Edit: This was first discussed here: #413

Before:
capture 2

After:
capture 1

@MoNTE48
Copy link
Contributor

MoNTE48 commented Feb 13, 2016

👍 =)

@C1ffisme
Copy link

Funny, I actually noticed this in my sub-game a while ago. Seems we both thought about this at about the same time. 👍

@paramat
Copy link
Contributor

paramat commented Feb 14, 2016

👍

@sofar
Copy link
Contributor

sofar commented Feb 14, 2016

I like, that makes it nice and clear. The transparent text wasn't helping with readability.

@0-afflatus
Copy link

👍

2 similar comments
@JurajVajda
Copy link

👍

@sfan5
Copy link
Member

sfan5 commented Feb 18, 2016

👍

@paramat
Copy link
Contributor

paramat commented Feb 18, 2016

Will merge soon.

@paramat
Copy link
Contributor

paramat commented Feb 19, 2016

1ab0fc1

@paramat paramat closed this Feb 19, 2016
@p5yg3n p5yg3n deleted the book-bg branch February 22, 2016 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants