Fix bug in dropped item counting #1067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yup, that's indeed a bug. |
|
Approval by nore http://irc.minetest.ru/minetest-dev/2016-05-03#i_4600735 |
|
@sofar happy with this PR? |
|
@paramat yes, sorry for not making that clear before. This is a correct fix. |
|
Thanks, 👍 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug while experimenting with the new TNT (btw, I love the new TNT). It's possible for more items to be dropped than were destroyed by the blast. 100% reproducible. Build 10 blocks of mese and destroy them all with a single TNT; 2 stacks of 9 mese each will be dropped. This is a simple fix.