TNT explosion custom sound #1823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to customise explosion sound when using tnt.boom()
|
Needs documentation: https://github.com/minetest/minetest_game/blob/master/game_api.txt#L290 |
add tnt sound info
|
Why? None of our other registered items have this ability, and an explosion sound works for all explosions. |
SmallJoker
approved these changes
Jul 9, 2017
|
Someone might want different explosion sounds - may it be for fun or to make it more realistic. |
|
The ability to add a custom sound is easily done here, give modders the option. |
|
No objection. |
|
@paramat - would it be find if I added the sound distance fix in here also, to save a new pull ? |
|
What needs fixing about the sound distance? And yes fine as a separate commit. |
This fixes max_hear_distance so it's not always set to 128, instead it uses radius * 20 with a max of 128 in total.
added missing bracket
|
👍 but either this should be squashed to 1 or to 2 commits, now it's 4 commits. |
|
Squash to 1 i think on merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to customise explosion sound when using tnt.boom() which can be used when creating custom tnt or when using other mods directly, it also fixes the 128 node max_hear_distance always being used by calculating the sound distance using the explosion radius.