New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creative: Prevent unauthorized item access #1840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
approved these changes
Jul 22, 2017
rubenwardy
approved these changes
Jul 22, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
mods/creative/inventory.lua
Outdated
else | ||
local name = player2 and player2:get_player_name() or "" | ||
if not creative.is_enabled_for(name) | ||
or to_list == "main" then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not creative.is_enabled_for(name) or
to_list == "main" then
Mods that reuse affected code should also be updated. |
paly2
pushed a commit
to MT-Eurythmia/minetest_game
that referenced
this pull request
Jul 23, 2017
AntumDeluge
pushed a commit
to AntumMT/game-minetest
that referenced
this pull request
Aug 16, 2017
sfan5
pushed a commit
that referenced
this pull request
Nov 19, 2017
sfan5
pushed a commit
that referenced
this pull request
Nov 19, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1839
Way 1 to check whether this works:
creative
creative
Way 2: Write a mod for #1839 (comment)