Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creative: Prevent unauthorized item access #1840

Merged
merged 1 commit into from Jul 22, 2017
Merged

Creative: Prevent unauthorized item access #1840

merged 1 commit into from Jul 22, 2017

Conversation

SmallJoker
Copy link
Member

Fixes #1839

Way 1 to check whether this works:

  1. Start a server and a client
  2. Grant the newly joined player creative
  3. Rejoin with that player
  4. Revoke creative
  5. With the remote player: Try to take items

Way 2: Write a mod for #1839 (comment)

Copy link
Member

@rubenwardy rubenwardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

else
local name = player2 and player2:get_player_name() or ""
if not creative.is_enabled_for(name)
or to_list == "main" then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not creative.is_enabled_for(name) or
		to_list == "main" then

@SmallJoker SmallJoker merged commit a1d35f3 into minetest:master Jul 22, 2017
@SmallJoker SmallJoker deleted the unleak_creative branch July 22, 2017 18:16
@Fixer-007
Copy link
Contributor

Mods that reuse affected code should also be updated.

paly2 pushed a commit to MT-Eurythmia/minetest_game that referenced this pull request Jul 23, 2017
@SmallJoker SmallJoker restored the unleak_creative branch July 27, 2017 19:06
AntumDeluge pushed a commit to AntumMT/game-minetest that referenced this pull request Aug 16, 2017
@SmallJoker SmallJoker deleted the unleak_creative branch October 23, 2017 18:30
@rubenwardy rubenwardy mentioned this pull request Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants