changed the formspec method

[pinkysnowman]

switched to table.concat() for faster loading

[kaeza]

Conflicts with #736, and is not needed for an operation that is not executed very often.

[asl97]

table.concat is slower than joining a bunch of string without needing to store them in a variable

unlike the sethome, the amount of args doesn't grow ether, it will always be the same amount of args

there no reason for this, this is slower than the current code.

[pinkysnowman]

I was under the impression ".." is slower

[kilbith]

👎 .. is already a concatenation meant for plain strings, you're basically using needlessly more ressources with table.concat (which is useful to use when your values are necessarily in an array and that is likely to be dynamically redefined).

The best way for optimizing this is to avoid the concatenation at all, i.e. make a long, continuous string (but you lost the readability).

Also rather bad-style deontologically to open a PR conflicting short after another.

[pinkysnowman]

And you guys wonder why noone gives a fuck about deving this engine

[asl97]

@pinkysnowman now that is just rude, what kilbith said is valid

@kilbith

• if 'newline' doesn't effect formspec, [[ and ]] could be use instead of long continuous string.
• pinkysnowman might not have known about that PR

[est31]

I've removed a particularly rude comment.

[0-afflatus]

I have to say I find use of terms like 'deontologically' somewhat egregious.