New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move documentation for game to markdown format. #799
Conversation
This blows away all git history, and many lines are similar before and after can you instead of copying, do
And then incrementally fix the markup format where needed? |
@sofar sorry about that I did do that but squashing removed it from history. Will fix soon. |
e7c3deb
to
0e5ca69
Compare
Does that mean two commits? |
0e5ca69
to
615ed02
Compare
Those 2 commits look fine to me - at least there's some coherence in what was changed, and unchanged lines are present (good). |
rubenwardy wrote > lua_api.txt is in markdown, but hasn't been renamed for some reason There may be a good reason for this, the document file should always be quickly and simply openable as a text document, as far as i can remember this was requested by celeron55. Our documents should always be primarily intended to be simple text documents even if they are in markdown format. |
It's no harder to open a .md document as a text then to open a .lua as a text and minetest modding requires a lot of the second. |
Sorry, you're probably right on that. Would opening a .md file in github display as text or MD? i prefer to see the text version. The MD version is friendlier for non-devs but devs i think prefer the real thing. |
github automatically displays all md files as markdown, not plain text. |
But you can click "raw" to view the raw file. |
Okay, i do remember c55 insisting on lua_api.txt remaining a txt file, and i agree, when i go to the file in github it will be irritating to need another step to see the actual text file, devs are used to it as text and want to see it like that. |
I prefer the good raw .txt format as well for not being polluted by script attributes and "fashion" shallowness. |
See commit message for minetest/minetest@800d912 |
Md/Html formats are much better for sharing links to, without worrying that the line number will change. However, you could just use lua_api.html. |
@kilbith It is perfectly readable as a text file, most of the changes made a very minor like changing a ' to a @paramat I don't think there are a lot of references to I guess you could always make |
@rubenwardy Is that up to date with lua_api.txt? |
I find the extra symbols hard on the eyes when viewed as text, i had just got used to lua_api.txt when it was unfortunately changed to MD format, i wish it had not been, a mistake i think. A carefully and cleanly formatted text document would be just as good, the MD format version should be maintained separately by whoever can be bothered to do that. |
Maintaing two versions is rather silly. Just learn to adapt. I am very glad it was standardised into markdown, makes linking much easier. |
Yeah i agree 2 versions would be problematic, inevitably one would lag behind and it's more work. So it's a case of what's more important, a friendly document for modders or a a cleaner text document for devs, difficult choice. Maybe these documents could be made clearer while still being in MD format. |
Okay with some thought, i'll support markdown format but will never support changing the file extension to .md. Markdown format is meant to be friendly but for a dev the text is preferable, more compact. After looking at lua_api.txt displayed as MD i don't find it an improvement, there's so much space between everything it's actually less clear to me. I'll +1 this if updated to be formatting only. |
This is exactly what bother me too. |
@paramat what do you find decrease the readability as text most? |
Just the general overuse of special symbols, instead of beng free to make it as clear as possible. |
Markdown is for people who find HTML difficult and should only be used in circumstances where the file is not going to be read in the raw. I use text files for my READMEs without the .txt extension. This may be because I have a bad attitude towards Windows users, however. |
Urr, no.
|
Point taken @rubenwardy - it just doesn't work for me. |
It fails then :) |
I'll +1 this if updated to be formatting only, please keep it .txt. |
@rubenwardy added extra spaces. |
Lines 261-294 seem to have inconsistent indentations of comments and varying number of spaces after the asterisks. In these comments some parameters are within '' some are not. I agree this is borderline non-trivial but due to elusive mtgame devs i'm happy to take the risk, we've had good input on this too from others. |
The indentation in the dyes section is inconsistent. Actually this document looks okay in MD format, lua_api.txt is a little harder on the eyes due to its density. |
The doors API patch is not yet merged, so this will conflict. I have various style fixes pending in the PR there, and will refresh that one depending on what gets merged first. |
This may need rebasing due to fences API being added. |
@paramat I prefer seeing patches merge quicker than attempting to choreograph a dance around dependencies, especially when it comes to documentation which shouldn't gate or be gated by anything. |
Agreed, it may not conflict. |
^ @red-001 |
This may need to be worked on by someone else as the author is absent. |
I'm back. |
Welcome back. |
Line 129: 'choppy = 2' please. |
Still needs rebasing. |
f27afd1
to
34ccc55
Compare
@sofar Rebased. |
Lines 28, 29, 37, 61: One less tab indent. Please add the new tree function: |
^ @red-001 Please update soon. |
34ccc55
to
271b617
Compare
@paramat Updated. |
👍 Will merge soon as trivial. |
This allows GitHub to display the documentation with proper styling making it easier to read and use as a reference.
See: #798.
Link to file in markdown