Feature/back top #40
Merged
Feature/back top #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakeUni
approved these changes
May 9, 2019
| console.log(msg) | ||
| } | ||
| window.matchMedia = () => ({}) | ||
| window.scrollTo = () => {} |
There was a problem hiding this comment.
再 mock 回去是把 window.scrollTo = null 嘛, 这样子没什么必要吧
There was a problem hiding this comment.
不是啊 是这样子的
const a = window.scrollTo
widow.scrollTo = () => {}
window.scrollTo = a
anyexinglu
approved these changes
May 9, 2019
| const [show, setShow] = useState(false) | ||
|
|
||
| const scrollLogic = () => { | ||
| if (window.scrollY >= 400) { |
There was a problem hiding this comment.
居然偷偷hard code（没使用visibilityHeight这个props）
| })} | ||
| onClick={backTopFn} | ||
| > | ||
| {children ? children : <Icon type="totop" color="#fff" />} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
测试用例中不识别 window.scrollTo 属性,
jest.config.js增加如下配置setup.js 如下: