Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP IAP (Identity Aware Proxy) #43

Closed
wants to merge 33 commits into from
Closed

GCP IAP (Identity Aware Proxy) #43

wants to merge 33 commits into from

Conversation

McSly
Copy link
Contributor

@McSly McSly commented Feb 26, 2020

Add icon for GCP IAP (Identity Aware Proxy)
See issue #33

S M and others added 30 commits February 15, 2020 21:09
* feat: add custom node class

* docs: add example about custom node

* docs: improve example about custom node usage

* docs: fix variable name
This allows you to have a consistent output filename, even if you decide
to tweak the diagram name.
@mingrammer
Copy link
Owner

mingrammer commented Feb 27, 2020

How did you extract that icon image? It looks blurry, unlike other icon images. (and its background is not transparent)

Screen Shot 2020-02-27 at 8 49 29 PM

@McSly
Copy link
Contributor Author

McSly commented Feb 27, 2020

I had a couple of versions for that image and I uploaded the wrong one. New version should be correct

@mingrammer
Copy link
Owner

Looks good. But could you please re-open the PR after cleaning the commit tree?

@mingrammer
Copy link
Owner

I close it. I added you as a co-author for #56. Thank you!

@mingrammer mingrammer closed this Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants