Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cloud IAP (Identity-Aware Proxy) #56

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Add Cloud IAP (Identity-Aware Proxy) #56

merged 2 commits into from
Mar 11, 2020

Conversation

przmv
Copy link
Contributor

@przmv przmv commented Mar 7, 2020

Fixes #33

@mingrammer
Copy link
Owner

Hmm .. duplicate of #43

@przmv
Copy link
Contributor Author

przmv commented Mar 9, 2020

@mingrammer Yes, but this one is with proper icon.

@mingrammer
Copy link
Owner

Ok, but since @McSly contributed first for this, what do you think of adding @McSly as a co-author to this commit?

Do you mind if I do this, @McSly? :)

@mingrammer mingrammer added the kind/feat/icon Icon request label Mar 10, 2020
@przmv
Copy link
Contributor Author

przmv commented Mar 10, 2020

I don't mind at all. I just need that icon 😄

@McSly
Copy link
Contributor

McSly commented Mar 11, 2020

Either option is fine with me. Sorry I didn't have time to complete the previous pull request

@mingrammer
Copy link
Owner

Thank you guys :)

@mingrammer mingrammer merged commit 3b56dde into mingrammer:master Mar 11, 2020
@mingrammer mingrammer mentioned this pull request Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/feat/icon Icon request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature - add GCP IAP (Identity Aware Proxy)
3 participants
@przmv @mingrammer @McSly