return early after err

miniflux · Sep 8, 2023 · 4664e37 · 4664e37
1 parent eada543
commit 4664e37
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/internal/ui/entry_scraper.go b/internal/ui/entry_scraper.go
@@ -37,9 +37,11 @@ func (h *handler) fetchContent(w http.ResponseWriter, r *http.Request) {
 	user, err := h.store.UserByID(entry.UserID)
 	if err != nil {
 		json.ServerError(w, r, err)
+		return
 	}
 	if user == nil {
 		json.NotFound(w, r)
+		return
 	}
 
 	feedBuilder := storage.NewFeedQueryBuilder(h.store, loggedUserID)
@@ -62,6 +64,7 @@ func (h *handler) fetchContent(w http.ResponseWriter, r *http.Request) {
 
 	if err := h.store.UpdateEntryContent(entry); err != nil {
 		json.ServerError(w, r, err)
+		return
 	}
 
 	readingTime := locale.NewPrinter(user.Language).Plural("entry.estimated_reading_time", entry.ReadingTime, entry.ReadingTime)
@@ -91,9 +94,11 @@ func (h *handler) fetchOriginal(w http.ResponseWriter, r *http.Request) {
 	user, err := h.store.UserByID(entry.UserID)
 	if err != nil {
 		json.ServerError(w, r, err)
+		return
 	}
 	if user == nil {
 		json.NotFound(w, r)
+		return
 	}
 
 	feedBuilder := storage.NewFeedQueryBuilder(h.store, loggedUserID)