Replace DomHelper.findParent with .closest

See https://developer.mozilla.org/en-US/docs/Web/API/Element/closest
miniflux · Mar 11, 2024 · 826e4d6 · 826e4d6
1 parent d9d17f0
commit 826e4d6
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 12 deletions.
diff --git a/internal/ui/static/js/app.js b/internal/ui/static/js/app.js
@@ -571,7 +571,7 @@ function isListView() {
 function findEntry(element) {
     if (isListView()) {
         if (element) {
-            return DomHelper.findParent(element, "item");
+            return element.closest(".item")
         } else {
             return document.querySelector(".current-item");
         }

diff --git a/internal/ui/static/js/dom_helper.js b/internal/ui/static/js/dom_helper.js
@@ -34,16 +34,6 @@ class DomHelper {
         return result;
     }
 
-    static findParent(element, selector) {
-        for (; element && element !== document; element = element.parentNode) {
-            if (element.classList.contains(selector)) {
-                return element;
-            }
-        }
-
-        return null;
-    }
-
     static hasPassiveEventListenerOption() {
         var passiveSupported = false;
 

diff --git a/internal/ui/static/js/touch_handler.js b/internal/ui/static/js/touch_handler.js
@@ -31,7 +31,7 @@ class TouchHandler {
             return element;
         }
 
-        return DomHelper.findParent(element, "entry-swipe");
+        return element.closest(".entry-swipe")
     }
 
     onItemTouchStart(event) {