Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored gem and tests and fixed a couple of problem areas for windows users #64

Merged
merged 9 commits into from
Dec 28, 2011
Merged

Conversation

2potatocakes
Copy link
Contributor

I'm in the process of upgrading an old behemoth of a program that used to use a much older version of mini_magick. The problem I have is that this particular program is always deployed on windows and the latest few versions of mini_magick don't seem to work properly on windows.

Anywho, there's problems associated with reading in IOStream's for windows users that causes a few things to break. I made a heap of changes to my local copy to get everything I need working again, pretty sure everything will still work on linux/mac so thought I'd send you a pull request.

I also pulled in WaYdotNET's fix for the combine options method. Cheers Carlo

All tests are now passing on Ruby 187 and 192 on windows.

But there is 1 catch, this version will need Subexec 0.2.1 with the pull request from tekn0t included.. or an equivalent: pressly/subexec#7

Anyways, up to you guys if you'd like to pull it in. Much appreciate the work you all do ;)

@HamptonMakes
Copy link
Member

I'm not sure this counts as a full "refactor", but a lot of the code was cleaned up.
I need to run these tests on Linux and Mac before I can fully bless it.

Also, can you please add to the CHANGELOG for update information.

Also, I'm fine with the programatic version stuff, but it needs to be semi-unified with
the VERSION file already provided.

@2potatocakes
Copy link
Contributor Author

Hi Hampton,
Yeah apologies on the wording of that commit, it's definitely not a full refactor. I was originally just going to make these changes in my local copy and didn't think I'd end up sending a pull request. I just moved some of the test files and stuff around a little, but the API and all its functions remain unchanged.
Also I just pulled out the version.rb file that I'd added and reverted it back to your original implementation as requested.
Hope it's ok. Cheers again guys ;)

@WaYdotNET
Copy link
Contributor

good job !

@HamptonMakes
Copy link
Member

Ok, I'm just waiting for subexec to include this... and I'll merge. I'm going to go bug that repo...

HamptonMakes added a commit that referenced this pull request Dec 28, 2011
Refactored gem and tests and fixed a couple of problem areas for windows users --- Got subexec version upgraded
@HamptonMakes HamptonMakes merged commit 45bb993 into minimagick:master Dec 28, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants