-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored gem and tests and fixed a couple of problem areas for windows users #64
Conversation
…xec also to run gem properly on windows
I'm not sure this counts as a full "refactor", but a lot of the code was cleaned up. Also, can you please add to the CHANGELOG for update information. Also, I'm fine with the programatic version stuff, but it needs to be semi-unified with |
Hi Hampton, |
good job ! |
Ok, I'm just waiting for subexec to include this... and I'll merge. I'm going to go bug that repo... |
Refactored gem and tests and fixed a couple of problem areas for windows users --- Got subexec version upgraded
I'm in the process of upgrading an old behemoth of a program that used to use a much older version of mini_magick. The problem I have is that this particular program is always deployed on windows and the latest few versions of mini_magick don't seem to work properly on windows.
Anywho, there's problems associated with reading in IOStream's for windows users that causes a few things to break. I made a heap of changes to my local copy to get everything I need working again, pretty sure everything will still work on linux/mac so thought I'd send you a pull request.
I also pulled in WaYdotNET's fix for the combine options method. Cheers Carlo
All tests are now passing on Ruby 187 and 192 on windows.
But there is 1 catch, this version will need Subexec 0.2.1 with the pull request from tekn0t included.. or an equivalent: pressly/subexec#7
Anyways, up to you guys if you'd like to pull it in. Much appreciate the work you all do ;)