Remove minio root credentials from CreateTenant response (#402)

Co-authored-by: Daniel Valdivia <hola@danielvaldivia.com>
minio · Nov 19, 2020 · 12e53a1 · 12e53a1
1 parent b21123e
commit 12e53a1
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 40 deletions.
diff --git a/models/create_tenant_response.go b/models/create_tenant_response.go
diff --git a/portal-ui/src/screens/Console/Common/CredentialsPrompt/CredentialsPrompt.tsx b/portal-ui/src/screens/Console/Common/CredentialsPrompt/CredentialsPrompt.tsx
@@ -82,14 +82,6 @@ const CredentialsPrompt = ({
         <Grid container>
           <Grid item xs={12} className={classes.formScrollable}>
             A new {entity} has been created with the following details:
-            <ul>
-              <li>
-                <b>Access Key:</b> {newServiceAccount.accessKey}
-              </li>
-              <li>
-                <b>Secret Key:</b> {newServiceAccount.secretKey}
-              </li>
-            </ul>
             {consoleCreds && (
               <React.Fragment>
                 <Grid item xs={12}>
@@ -131,8 +123,6 @@ const CredentialsPrompt = ({
                 download(
                   "credentials.json",
                   JSON.stringify({
-                    access_key: newServiceAccount.accessKey,
-                    secret_key: newServiceAccount.secretKey,
                     ...consoleExtras,
                   })
                 );

diff --git a/portal-ui/src/screens/Console/Common/CredentialsPrompt/types.ts b/portal-ui/src/screens/Console/Common/CredentialsPrompt/types.ts
@@ -15,8 +15,6 @@
 // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 export interface NewServiceAccount {
-  accessKey: string;
-  secretKey: string;
   console?: ConsoleSA;
 }
 

diff --git a/portal-ui/src/screens/Console/Tenants/ListTenants/AddTenant.tsx b/portal-ui/src/screens/Console/Tenants/ListTenants/AddTenant.tsx
@@ -913,8 +913,6 @@ const AddTenant = ({
         .invoke("POST", `/api/v1/tenants`, dataSend)
         .then((res) => {
           const newSrvAcc: NewServiceAccount = {
-            accessKey: res.access_key,
-            secretKey: res.secret_key,
             console: {
               accessKey: res.console.access_key,
               secretKey: res.console.secret_key,

diff --git a/restapi/admin_tenants.go b/restapi/admin_tenants.go
@@ -778,10 +778,7 @@ func getTenantCreatedResponse(session *models.Principal, params admin_api.Create
 			return nil, prepareError(err)
 		}
 	}
-	response = &models.CreateTenantResponse{
-		AccessKey: accessKey,
-		SecretKey: secretKey,
-	}
+	response = &models.CreateTenantResponse{}
 	// Attach Console Credentials
 	if enableConsole {
 		response.Console = &models.CreateTenantResponseConsole{

diff --git a/restapi/embedded_spec.go b/restapi/embedded_spec.go
diff --git a/swagger.yml b/swagger.yml
@@ -2967,10 +2967,6 @@ definitions:
   createTenantResponse:
     type: object
     properties:
-      access_key:
-        type: string
-      secret_key:
-        type: string
       console:
         type: object
         properties: