config set should always use on/off not true/false (#1899)

fixes minio/minio#14516
minio · Apr 25, 2022 · 275d87f · 275d87f
1 parent 509f495
commit 275d87f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/portal-ui/src/screens/Console/NotificationEndpoints/ConfTargetGeneric.tsx b/portal-ui/src/screens/Console/NotificationEndpoints/ConfTargetGeneric.tsx
@@ -52,7 +52,7 @@ export const valueDef = (
   type: string,
   defaults: IElementValue[]
 ) => {
-  let defValue = type === "on|off" ? "false" : "";
+  let defValue = type === "on|off" ? "off" : "";
 
   if (defaults.length > 0) {
     const storedConfig = defaults.find((element) => element.key === key);
@@ -105,20 +105,20 @@ const ConfTargetGeneric = ({
   const fieldDefinition = (field: KVField, item: number) => {
     switch (field.type) {
       case "on|off":
-        const value = valueHolder[item] ? valueHolder[item].value : "false";
+        const value = valueHolder[item] ? valueHolder[item].value : "off";
 
         return (
           <FormSwitchWrapper
             onChange={(e: React.ChangeEvent<HTMLInputElement>) => {
-              const value = e.target.checked ? "true" : "false";
+              const value = e.target.checked ? "on" : "off";
               setValueElement(field.name, value, item);
             }}
             id={field.name}
             name={field.name}
             label={field.label}
             value={"switch_on"}
             tooltip={field.tooltip}
-            checked={value === "true"}
+            checked={value === "on"}
           />
         );
       case "csv":