Add ability to disable the share redirect feature #3351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the ENV variable `CONSOLE_BROWSER_REDIRECT` to disable the feature introduced in minio#3348 since it is only needed when the MinIO server is not publically reachable. It defaults to `on` to keep current behaviour. Resolves minio#3348.
hashworks
force-pushed
the
feature/disable_share_redirect_by_env
branch
from
9896c3b
to
dc6303e
Compare
|
Thanks for sending the PR, I answered in the issue #3348 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the ENV variable
CONSOLE_BROWSER_REDIRECTto disable the feature introduced in #3348 since it is only needed when the MinIO server is not publically reachable.It defaults to
onto keep current behaviour.Resolves #3348.