Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable Console as proxy for share object logic #3348

Closed
hashworks opened this issue May 14, 2024 · 4 comments
Closed

Add ability to disable Console as proxy for share object logic #3348

hashworks opened this issue May 14, 2024 · 4 comments

Comments

@hashworks
Copy link

hashworks commented May 14, 2024

#3284 has its use case, but introduced some bugs (#3305, #3328, #3334).

Expected Behavior

Users can decide if they want to use Console as a proxy for the share logic.

Current Behavior

Users are forced to use this new feature.

Possible Solution

It would be great if one could disable this feature using an environment variable (f.e. MINIO_BROWSER_PROXY_SHARE=false, default true), since it introduced unneeded complexity if the MINIO_SERVER_URL is publically accessible.

Steps to Reproduce (for bugs)

Run a MinIO cluster with a recent Console version and run into the linked bugs.

Context

The new feature broke the share functionality on our production cluster since not all fixes are provided in the latest version (1.4.0).

Regression

This wasn't needed before #3284.

@pjuarezd
Copy link
Member

pjuarezd commented May 20, 2024

Hi @hashworks, can you please share with us what is the issue with going through MinIO Console? we are curious.
Also you can use the mc command line to get the files URL directly from MinIO if that helps

@hashworks
Copy link
Author

We are currently affected by #3334 - its fix is not included in the latest stable release (1.4.0). Share URLs created by console need to be fixed manually (/ui/ path prefix in our case).

I'm aware that the mc command line can create direct links, but I can't expect that from web interface users.

The redirect is simply not needed if the MinIO server is publically reachable, so it seems reasonable that it's an optional feature.

@hashworks
Copy link
Author

Looks like it simply would require a flag-check to skip those three lines and return minioURL instead.

hashworks added a commit to hashworks/console that referenced this issue May 21, 2024
Introduces the ENV variable `CONSOLE_BROWSER_REDIRECT` to disable the
feature introduced in minio#3348 since it is only needed when the MinIO
server is not publically reachable.

It defaults to `on` to keep current behaviour.

Resolves minio#3348.
hashworks added a commit to hashworks/console that referenced this issue May 22, 2024
Introduces the ENV variable `CONSOLE_BROWSER_REDIRECT` to disable the
feature introduced in minio#3348 since it is only needed when the MinIO
server is not publically reachable.

It defaults to `on` to keep current behaviour.

Resolves minio#3348.
@cesnietor
Copy link
Collaborator

@hashworks take a look at the latest release, it should be there.
Adding an env variable to disable this is not the right approach but rather fixing the bugs that we encounter. Cause if you already have access to console, then the share url will have access to it.
If you have access to the server then you can use mc.
If there is a special scenario on why this feature might cause some issues, please let us know but latest release should address the issue you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants