-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to disable Console as proxy for share object logic #3348
Comments
Hi @hashworks, can you please share with us what is the issue with going through MinIO Console? we are curious. |
We are currently affected by #3334 - its fix is not included in the latest stable release (1.4.0). Share URLs created by console need to be fixed manually ( I'm aware that the The redirect is simply not needed if the MinIO server is publically reachable, so it seems reasonable that it's an optional feature. |
Looks like it simply would require a flag-check to skip those three lines and return |
Introduces the ENV variable `CONSOLE_BROWSER_REDIRECT` to disable the feature introduced in minio#3348 since it is only needed when the MinIO server is not publically reachable. It defaults to `on` to keep current behaviour. Resolves minio#3348.
Introduces the ENV variable `CONSOLE_BROWSER_REDIRECT` to disable the feature introduced in minio#3348 since it is only needed when the MinIO server is not publically reachable. It defaults to `on` to keep current behaviour. Resolves minio#3348.
@hashworks take a look at the latest release, it should be there. |
#3284 has its use case, but introduced some bugs (#3305, #3328, #3334).
Expected Behavior
Users can decide if they want to use Console as a proxy for the share logic.
Current Behavior
Users are forced to use this new feature.
Possible Solution
It would be great if one could disable this feature using an environment variable (f.e.
MINIO_BROWSER_PROXY_SHARE=false
, defaulttrue
), since it introduced unneeded complexity if theMINIO_SERVER_URL
is publically accessible.Steps to Reproduce (for bugs)
Run a MinIO cluster with a recent Console version and run into the linked bugs.
Context
The new feature broke the share functionality on our production cluster since not all fixes are provided in the latest version (1.4.0).
Regression
This wasn't needed before #3284.
The text was updated successfully, but these errors were encountered: